search

eslint / espree

An Esprima-compatible JavaScript parser
BSD 2-Clause "Simplified" License
2.26k stars 189 forks source link

Build: remove browserify script #466

Closed mdjermanovic closed 3 years ago

mdjermanovic commented 3 years ago

Removes browserify script.

It doesn't look like we're publishing the bundle it creates, or using the script/bundle for anything, so it seems there is no point in maintaining the script.

Note: npm run sync-docs updated docs/README.md with some unrelated changes that were not synced before.

nzakas commented 3 years ago

Just to double check, can you verify that this isn’t being used by the main repo when we do a release?

mdjermanovic commented 3 years ago

Just to double check, can you verify that this isn’t being used by the main repo when we do a release?

I'm pretty sure we're not using this in eslint/espree, eslint/eslint and eslint/website repos, though wouldn't mind if someone else could also verify that.

The browserify script runs Makefile.js to create build/espree.js.

Neither of Makefile.js and build/espree.js is among the files we publish to npm registry:

https://github.com/eslint/espree/blob/3b4ca9e3141514ffac93bb7fef6c1329370df310/package.json#L8-L11

Our ESLint demo is here. The website build first installs dependencies of the ESLint demo from npm. The only direct dependency is "eslint": "latest". Espree will be installed from npm as a dependency of ESLint, without Makefile.js and build/espree.js files as they were not published.

website build then runs webpack to make demo.js, and webpack bundles Espree like all other dependencies.

The main eslint/eslint repo also uses webpack to test Linter in browsers.

As far as I'm aware, we don't have any Espree demos anymore, there's only ESLint demo.