search

eslint / espree

An Esprima-compatible JavaScript parser
BSD 2-Clause "Simplified" License
2.26k stars 189 forks source link

Breaking: acorn to 8.1.0 (fixes #470) #473

Closed aladdin-add closed 3 years ago

aladdin-add commented 3 years ago

fixes #470

changelog: https://github.com/acornjs/acorn/blob/master/acorn/CHANGELOG.md#breaking-changes

mdjermanovic commented 3 years ago

Upgrading to acorn 8 is a breaking change for espree, as discussed in https://github.com/eslint/espree/pull/456.

https://github.com/eslint/espree/pull/469 also upgrades to acorn 8, so maybe we could just make an additional chore PR with tests for #470 and #472.

aladdin-add commented 3 years ago

I think this is ready to be reviewed and merged. 🚀

But if #469 get merged before this one. I will update the title to "Chore" as @mdjermanovic suggested.