Closed mdjermanovic closed 3 years ago
I agree that it doesn't make sense to commit the changed version.js
into the repo. It's a simpler release process if update the file during the release and then discard it.
It looks like we can handle a lot of this complexity by using a prepare
script, which will run before npm test
and also before npm publish
.
After we merge https://github.com/eslint/espree/pull/469, we should update the release process to account for an additional build step.
The new build step (
npm run rollup
in https://github.com/eslint/espree/pull/469) does two things:package.json
to updatelib/version.js
.dist/espree.cjs
.Current steps in generateRelease are:
npm test
.npm version
to updatepackage.json
. commit that change, and create git tag.But now we should have something like this:
npm version
to updatepackage.json
. commit that change, and create git tag.npm run rollup
.npm test
An additional question is whether or not should we commit
lib/version.js
. It might make sense to have a fixed"master"
(or"main"
) as the version string in the repo.Previous discussion: https://github.com/eslint/espree/pull/469#discussion_r584326147