Closed mysticatea closed 3 years ago
Hmmm. The build step makes developing new syntax on cross-packages difficult. 😟
npm install github:eslint/espree#class-fields
doesn't work because dist
doesn't exist. Are any alternative ways?
for local development, you can use npm link
However, I don't think there is an easy way to run on CI.
npm install github:eslint/espree#class-fields
doesn't work becausedist
doesn't exist. Are any alternative ways?
Maybe comment out dist
in .gitignore
, build locally and push dist/
to this branch (we should revert that before merging).
Switched to a draft for work-in-progress changes.
You can also use a preinstall npm script. That might be easier to remove before merging.
@mysticatea what is left to do on this PR? Is anything we can help with?
@mysticatea seems it is ready to go (the deps has been released & updated).
Any news?
@sanex3339 all news is posted on the pull request.
There are merge conflicts that should be resolved
Yup, all fixed now.
Thank you for this PR
WIP.
This PR adds ES2022 class features.
Remaining steps:
dist
.eslint-visitor-keys
.eslint-visitor-keys
version range in package.json.Also, because I expect ESLint built-in rules have false positives about the new syntax, I hope to release this feature together with built-in rules updates.