fix: Derive espree.Syntax from espree.VisitorKeys

eslint / espree

An Esprima-compatible JavaScript parser

BSD 2-Clause "Simplified" License

2.26k stars 189 forks source link

fix: Derive espree.Syntax from espree.VisitorKeys #532

Closed codeworrior closed 2 years ago

codeworrior commented 2 years ago

Fixes #531.

If removing the lib/ast-node-types.js is regarded as an incompatible change, I can restore it and leave the cleanup up to you in one of the upcoming major releases. My assumption was that the module is rather an internal thing and not part of your APIs.

linux-foundation-easycla[bot] commented 2 years ago

The committers are authorized under a signed CLA.

:white_check_mark: Frank Weigel (6ea491e581ea4743683a1e5071e9c0bcef9ec8d8, a3e88ae6da30e51a752624d8f830900e4fae012d)

eslint-github-bot[bot] commented 2 years ago

Hi @codeworrior!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
There should be a space following the initial tag and colon, for example 'feat: Message'.
The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

codeworrior commented 2 years ago

Sorry for not immediately signing the CLA. I have to clarify with my employer first.

codeworrior commented 2 years ago

Sorry for the delay. After my employer decided to sign the corporate CLA, we struggled a bit with the process and tooling, but now we're done.

mdjermanovic commented 2 years ago

Thanks for contributing!