eslint / generator-eslint

A Yeoman generator to help with ESLint development
Other
230 stars 51 forks source link

Remove JSDoc file comments from generated files #109

Closed bmish closed 3 years ago

bmish commented 3 years ago

I'm not a fan of the JSDoc comments that we add to the top of all the generated JavaScript files (rule implementation file, test file, etc):

/**
 * @fileoverview <%= desc %>
 * @author <%= userName %>
 */

Why not?

What do you think? Let me know if anyone actually finds these comments valuable.

nzakas commented 3 years ago

I’m the one who implemented this because I like having a summary of what the file is and who created it at the top. I don’t like being dropped right into a file with no context. The author name is helpful not just to know who created it (sometimes I’m shocked to see that it’s me) but also to give people credit for their work.

Removing this means people will need to manually add it back in for core rules, which the generator is also intended to be used for.

If we decide the generator isn’t to be used for core rules anymore, then I’m fine with removing it (though I’d argue at least the file overview comment should be considered a best practice).

bmish commented 3 years ago

Thanks for the explanation, it's helpful to understand how others find value in this JSDoc comment. Since you are in favor of keeping this JSDoc comment, I'm fine to close this.