docs: align readme node.js with package.json - Githubissues

eslint / generator-eslint

A Yeoman generator to help with ESLint development

Other

227 stars 51 forks source link

docs: align readme node.js with package.json #183

Closed MikeMcC399 closed 3 months ago

MikeMcC399 commented 3 months ago

Issue

PR https://github.com/eslint/generator-eslint/pull/169 bumped the Node.js requirements to

https://github.com/eslint/generator-eslint/blob/92a44afb6bb04bd7b247111aa9d0f2c2b07558b2/package.json#L53-L55

whilst README > Installation was left unchanged stating

Requirements

Node.js ^14.17.0 || ^16.0.0 || >= 18.0.0

Change

README > Installation is updated to read

Requirements

Node.js ^18.18.0 || ^20.9.0 || >=21.1.0

in line with package.json

aladdin-add commented 3 months ago

yes, I had updated it in https://github.com/eslint/generator-eslint/pull/179.

MikeMcC399 commented 3 months ago

@aladdin-add

If #179 will be merged soon, then you could skip over this PR and close it.
If #179 will be delayed significantly, I think it makes sense to correct the information now.

aladdin-add commented 3 months ago

right, I'm merging it now.