eslint / json

JSON language plugin for ESLint
Apache License 2.0
18 stars 2 forks source link

feat: Export internal constructs for other plugin authors #17

Closed Sidnioulz closed 1 month ago

Sidnioulz commented 1 month ago

Prerequisites checklist

What is the purpose of this pull request?

Exports internal JSONLanguage and JSONSourceCode classes to allow further specialisation, so that plugins for JSON-based domain-specific languages can reuse that code without copying it.

What changes did you make? (Give an overview)

Related Issues

This was requested to the JSON plugin maintainer on Discord. Happy to open an issue for traceability if desired.

Is there anything you'd like reviewers to focus on?

nzakas commented 1 month ago

Looks like there's a validation error. Can you run npm run fmt and re-push?

Sidnioulz commented 1 month ago

Looks like there's a validation error. Can you run npm run fmt and re-push?

Oops! I'm too used to having this on file save in my IDE for my own projects, forgot to check for it :)

ipanasenko commented 1 month ago

I think this is exactly what was missing for me, when I tried to write my own json plugin, thanks! ❤️