ci: add Node.js v23 - Githubissues

eslint / json

JSON language plugin for ESLint

Apache License 2.0

44 stars 4 forks source link

ci: add Node.js v23 #44

Closed snitin315 closed 4 weeks ago

snitin315 commented 1 month ago

Prerequisites checklist

[x] I have read the contributing guidelines.

What is the purpose of this pull request?

What changes did you make? (Give an overview)

Add Node.js v23 environment

Related Issues

Is there anything you'd like reviewers to focus on?

amareshsm commented 1 month ago

LGTM, thanks! But there are other checks failing. We should fix those problems first I think.

In local I am not getting errors. I check in the node v20 and 22.

fasttime commented 1 month ago

In local I am not getting errors. I check in the node v20 and 22.

I am getting errors locally after deleting node_modules and running npm install again and then npm run build.

amareshsm commented 1 month ago

In local I am not getting errors. I check in the node v20 and 22.

I am getting errors locally after deleting node_modules and running npm install again and then npm run build.

ya, I am also getting errors after deleting and installing node_modules.

snitin315 commented 4 weeks ago

@fasttime @nzakas Done!