search

eslint / json

JSON language plugin for ESLint
Apache License 2.0
46 stars 4 forks source link

Change Request: Correct types for `configs` #52

Closed burtek closed 1 week ago

burtek commented 2 weeks ago

Environment

ESLint version: 9.14.0 @eslint/json version: 0.6.0 Node version: 20.9.0 npm version: 10.1.0 Operating System: LMDE 6, kernel 6.1.0-26-amd64

What problem do you want to solve?

The json plugin typings is wrong as it exports config property as {} Image This causes errors in IDE: Image

What do you think is the correct solution?

The configs property of the plugin should be typed correctly.

Participation

Additional comments

No response

fasttime commented 2 weeks ago

Thanks for reporting this problem @burtek. I can confirm that the configs property of the plugin is currently typed as an empty object. I've submitted a pull request that shoul fix the types: #59.

burtek commented 2 weeks ago

@fasttime btw, same probably needs to be done in eslint/markdown repo (https://github.com/eslint/markdown/blob/main/src/index.js), but I'm not using it so just mentioning it

fasttime commented 2 weeks ago

@burtek yes, we should fix also eslint/markdown and eslint/css. I'll take care of that.