eslint / markdown

Lint JavaScript code blocks in Markdown documents
MIT License
406 stars 63 forks source link

feat!: bump `mdast-util-from-markdown` with `synckit` #229

Closed JounQin closed 6 months ago

JounQin commented 11 months ago

close #218, drop node 12

mdast-util-from-markdown is ESM only now, synckit makes it possible to require ESM only module in commonjs without await import().

cc @btmills @nzakas

nzakas commented 11 months ago

We don't want to drop Node 12 until we release ESLint v9, which will also drop Node.js 12.

Is there a reason we can't use mdast-util-from-markdown 0.8.5 for now?

JounQin commented 11 months ago

It requires outdated unified related packages may results conflict/duplicate dependencies.

nzakas commented 11 months ago

Okay, We'll still need to wait until ESLint v9 to drop Node.js 12 support. At that point, we need to update Node.js support for all packages.

JounQin commented 11 months ago

@nzakas

image

synckit@v0.7 supports Node 12, would that be acceptable? I can patch Node v12 support back on v0.8 either.

JounQin commented 10 months ago

Friendly ping @nzakas

nzakas commented 10 months ago

We just released ESLint v9.0.0-alpha, so I think we can formally update the Node.js support for this package now.

Can you submit a PR like this? https://github.com/eslint/eslint-scope/pull/115

JounQin commented 10 months ago

@nzakas

Wow, that's really a big change, I was thinking to keep compatible, not ESLint v9 only. Because in case the big breaking changes on eslint v9, I believe the migration could be very slow.

JounQin commented 9 months ago

@nzakas Any further discussion?

aladdin-add commented 6 months ago

@JounQin it has dropped node.js < 18 supports. what's the next steps here?

JounQin commented 6 months ago

@aladdin-add Didn't notice that, I've updated the PR accordingly.

nzakas commented 6 months ago

At this point, I don't think we should move further with this PR. It's not fixing any bugs and adding in a new dependency just to upgrade some other module doesn't seem like a good tradeoff.