eslint / markdown

Lint JavaScript code blocks in Markdown documents
MIT License
406 stars 63 forks source link

chore: release 6.0.0 🚀 #261

Closed github-actions[bot] closed 3 months ago

github-actions[bot] commented 3 months ago

:robot: I have created a release beep boop

6.0.0 (2024-07-16)

⚠ BREAKING CHANGES

Features

Bug Fixes


This PR was generated with Release Please. See documentation.

mdjermanovic commented 3 months ago

Looks like it included all commits with releasable tags from the main branch. Seems like we need to specify bootstrap-sha when switching from release-please v3 to v4?

mdjermanovic commented 3 months ago

Or perhaps this is a problem with tags.

❯ looking for tagName: eslint-plugin-markdown-v5.1.0

https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md#subsequent-versions

The current setup will be creating and looking for tags in the format eslint-plugin-markdown-v<release-version> but we were using tags in the format v<release-version>, so the question is should we continue using the old format (and update tags settings in the release please config) or switch to the new format (in which case we'd probably need to specify bootstrap-sha)?

nzakas commented 3 months ago

Yeah, I figured something would break and we'd need to adjust. Just wanted to see what broke first. :) I'll take a look.

mdjermanovic commented 3 months ago

Okay, seems like https://github.com/eslint/eslint-plugin-markdown/commit/618a9f58fdf00d1176c7237b56799ee03cdde96d fixed this.

https://github.com/eslint/eslint-plugin-markdown/actions/runs/9977023767/job/27570640115

...
❯ Found release for path ., v5.1.0
❯ release for path: ., version: 5.1.0, sha: f75e14d9729a6107649d19cf540cc5385588fc4d
...
✔ No user facing commits found since f75e14d9729a6107649d19cf540cc5385588fc4d - skipping

Just looks like it doesn't close existing release PRs, so I'll close this manually.