search

eslint / rewrite

Monorepo for the new version of ESLint
Apache License 2.0
145 stars 11 forks source link

build: avoid unnecessary steps in release-please workflow #10

Closed mdjermanovic closed 4 months ago

mdjermanovic commented 4 months ago

Fixes https://github.com/eslint/rewrite/issues/8

In GitHub actions, steps' output properties always have string values.

Per https://github.com/google-github-actions/release-please-action/issues/912 and https://github.com/google-github-actions/release-please-action/pull/915, a breaking change in release-please-action@v4 is that when there are no releases created, instead of omitting releases_created property it sets it to a truthy string "false".

This PR updates the condition if: ${{ steps.release.outputs.releases_created }} to if: ${{ steps.release.outputs.releases_created == 'true' }} to avoid running unnecessary steps when there are no releases created.

aladdin-add commented 4 months ago

there is a conflict now.

aladdin-add commented 4 months ago

working as expected: https://github.com/eslint/rewrite/actions/runs/8999594116/job/24722063884