eslint / rewrite

Monorepo for the new version of ESLint
Apache License 2.0
145 stars 11 forks source link

feat: Add types to config-array #3

Closed nzakas closed 4 months ago

nzakas commented 5 months ago

This adds type checking to the config-array package, generating types for both ESM and CJS.

eslint-github-bot[bot] commented 5 months ago

Hi @nzakas!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

nzakas commented 5 months ago

@mdjermanovic would like your review here to get this moving.

nzakas commented 4 months ago

Looks like packages aren't being properly built in CI, so I created a script to ensure packages are built in the correct order so tsc will be happy.

kecrily commented 4 months ago

Removing prepare script breaks the release workflow. This is because the current workflow does not run build script before NPM publish, but instead relies on installing and executing prepare at the same time. Also JSR publish have a separate build step.

We can remove the prepare scripts for all packages and the JSR publish builds from the workflow, and then add the prepare - build script to the workspace root


But I'm sure this can be fixed in another PR

nzakas commented 4 months ago

prepare is not going to work in this repo. I've added a build step to the release workflow to account for that.