eslint / rewrite

Monorepo for the new version of ESLint
Apache License 2.0
65 stars 4 forks source link

refactor: Use `eslint-config-eslint` for linting this repo #43

Closed mdjermanovic closed 3 weeks ago

mdjermanovic commented 3 weeks ago

Prerequisites checklist

What is the purpose of this pull request?

Updates eslint config to use eslint-config-eslint.

What changes did you make? (Give an overview)

Related Issues

No.

Is there anything you'd like reviewers to focus on?

I left two things for follow-ups (I'll open separate issues when this is merged):

  1. eslint-plugin-jsdoc rules are disabled for now. Enabling these rules will need special attention because we're using JSDoc to generate types.
  2. I'm not sure if we're getting all checks from eslint-plugin-n because linted files are not published.
nzakas commented 3 weeks ago

Rather than using eslint-config-prettier, could we just create a config in eslint-config-eslint that doesn't include formatting rules?

mdjermanovic commented 3 weeks ago

Rather than using eslint-config-prettier, could we just create a config in eslint-config-eslint that doesn't include formatting rules?

Good idea! I'll make a PR for this in eslint/eslint.

mdjermanovic commented 3 weeks ago

Here's the PR: https://github.com/eslint/eslint/pull/18560

mdjermanovic commented 3 weeks ago

Updated to eslint-config-eslint v11 and removed eslint-config-prettier now.