Change Request: Remove `ConfigArray#isExplicitMatch()` - Githubissues

eslint / rewrite

Monorepo for the new version of ESLint

Apache License 2.0

65 stars 4 forks source link

Change Request: Remove `ConfigArray#isExplicitMatch()` #51

Closed mdjermanovic closed 2 weeks ago

mdjermanovic commented 3 weeks ago

Which packages would you like to change?

[ ] @eslint/compat
[X] @eslint/config-array
[ ] @eslint/migrate-config
[ ] @eslint/object-schema

What problem do you want to solve?

ConfigArray#isExplicitMatch() is out of sync with the rest of the logic of config-array, and we're not using this method in ESLint anymore.

What do you think is the correct solution?

Remove ConfigArray#isExplicitMatch() method.

Participation

[X] I am willing to submit a pull request for this change.

Additional comments

No response

nzakas commented 3 weeks ago

Makes sense to me. There's a bunch of other logic I think we can remove now, too, specifically around including functions and arrays in the array. We're not using those features, so I don't think it makes sense to leave them in at this point.