Open benmccann opened 1 week ago
We're using minimatch v3 in ESLint too, for both flat and eslintrc config functionalities. We're also using minimatch v3 in @eslint/eslintrc
, which is still a dependency of ESLint. So if we upgrade only here, there will still be minimatch v3 in the dependency tree, which is probably not what we want. Since we'd prefer not to make any changes in eslintrc code at this point, I think it would be better to postpone this upgrade for ESLint v10, when we'll remove everything related to eslintrc.
@eslint/eslint-tsc thoughts?
IIRC, the reason we haven't upgraded is because it looked like there were some changes in functionality that caused our tests to break. I don't see any compelling reason to upgrade right now.
We can definitely think about this for v10, though we should keep in mind that this package will be depended by v9 as well, which should affect how we manage semver around this.
Which packages would you like to change?
@eslint/compat
@eslint/config-array
@eslint/migrate-config
@eslint/object-schema
What problem do you want to solve?
Upgrading to a newer version would reduce the number of dependencies and allow the remaining dependencies to dedupe better
https://github.com/eslint/rewrite/blob/85018903815908bcfd940bbda347f3f17663e4bd/packages/config-array/package.json#L51
What do you think is the correct solution?
version 9 is now available. if it's a difficult upgrade perhaps upgrading to an intermediate version would be an easier step
Participation
Additional comments
No response