eslint / rewrite

Monorepo for the new version of ESLint
Apache License 2.0
65 stars 4 forks source link

fix: skip add plugin when already imported #70

Closed syi0808 closed 4 days ago

syi0808 commented 5 days ago

Prerequisites checklist

What is the purpose of this pull request?

prevent syntax error which threw by duplicate import fixupPluginRules because of multiple compat needs plugins.

What changes did you make? (Give an overview)

Related Issues

fixes #72

Is there anything you'd like reviewers to focus on?

linux-foundation-easycla[bot] commented 5 days ago

CLA Signed


The committers listed above are authorized under a signed CLA.

eslint-github-bot[bot] commented 5 days ago

Hi @syi0808!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

nzakas commented 5 days ago

Thanks for the contribution. We need you to fill out a bug report before we can consider this.

syi0808 commented 5 days ago

Thanks for the contribution. We need you to fill out a bug report before we can consider this.

I fill out a bug report and connect this pr. thank you!

nzakas commented 4 days ago

@syi0808 we also need you to sign the CLA. Please see the comment posted by the bot.

syi0808 commented 4 days ago

Changes LGTM. Just need the CLA signed to merge.

I'm sorry to have made you check many times. I signed CLA now. thank you!

nzakas commented 4 days ago

No worries. Thank you!