eslint / rewrite

Monorepo for the new version of ESLint
Apache License 2.0
141 stars 11 forks source link

Change Request: New "helper" package for plugins #97

Closed nzakas closed 3 weeks ago

nzakas commented 1 month ago

Which packages would you like to change?

What problem do you want to solve?

Now that I've worked on a couple of language plugins, it's clear that there's some duplication of logic that each language could have. For instance:

What do you think is the correct solution?

Rather than forcing everyone to write their own versions of this logic, it would be helpful to create a package that contains common utilities for language development.

Maybe @eslint/language? Or @eslint/plugin or @eslint/plugin-kit (to disambiguate with ESLint plugins and make it a more generic plugin helper package rather than a language plugin package?)

Participation

Additional comments

No response

fasttime commented 1 month ago

I think this could be useful also to simplify the implementation of certain language-agnostic functionality that I've seen re-invented in different plugins (for processors in particular, but there should be more use cases). For utilities not strictly related to languages, a package name like @eslint/plugin or @eslint/plugin-kit should fit well. Opinions @eslint/eslint-team?

mdjermanovic commented 1 month ago

@eslint/plugin-kit (to disambiguate with ESLint plugins and make it a more generic plugin helper package rather than a language plugin package?)

@eslint/plugin-kit sounds good to me for the above reasons 👍

nzakas commented 1 month ago

Okay! I'll get started on this.