search

eslint / typescript-eslint-parser

An ESLint custom parser which leverages TypeScript ESTree to allow for ESLint to lint TypeScript source code.
Other
915 stars 75 forks source link

Breaking: Support TypeScript 2.8 (fixes #453) #454

Closed JamesHenry closed 6 years ago

JamesHenry commented 6 years ago

No changes were required to support the existing tests.

We should look to add coverage for new features introduced in 2.8 before this gets merged and check we are aligned with Babylon.

As per our existing conventions, this change is marked as Breaking despite the lack of breaking code changes. This is to be explicit to users that the change is significant within their setup. Also this branch is now protected as usual, so upstream master changes (if any) will need to be merged into this branch.

nevir commented 6 years ago

TSMinusToken and TSPlusToken are probably the main things this'll run into; though ts-eslint-parser doesn't complain about them, currently (v14.0.0). References:

lednhatkhanh commented 6 years ago

Hope to see this being merged soon.

iakovmarkov commented 6 years ago

Is there something that is blocking the merge? Can we help somehow? I'd love to see TS 2.8 being supported.