Fix: decorators removed on interface declarations (fixes #478)

eslint / typescript-eslint-parser

An ESLint custom parser which leverages TypeScript ESTree to allow for ESLint to lint TypeScript source code.

Other

915 stars 92 forks source link

Fix: decorators removed on interface declarations (fixes #478) #479

Closed muhanadra closed 6 years ago

muhanadra commented 6 years ago

This pull request fixes a bug that where decorators(invalid) on interface declarations are removed from the AST.

There was already a case where semantically invalid decorators are kept for enum declarations, so I followed the same logic for this case as well.

Looking forward to hearing your feedback.

Regards,

jsf-clabot commented 6 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Muhanad Abdalla seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

JamesHenry commented 6 years ago

This LGTM, @muhanadra, thanks!

The license agreement needs to be resolved before this can be merged, however. This is standard across all ESLint repos.

muhanadra commented 6 years ago

Hello @JamesHenry,

I already resolved the license agreement by correcting the email and the name in the commit to match my GitHub account and I signed the CLA agreement.

JamesHenry commented 6 years ago

Ah, sorry I missed that! Thanks again

muhanadra commented 6 years ago

@JamesHenry Thank you! This is my first bug fix on an open source project. Feeling kinda happy it went smoothly. Cheers!

JamesHenry commented 6 years ago

Awesome! 🙌 Thanks a lot for contributing :)