search

eslint / typescript-eslint-parser

An ESLint custom parser which leverages TypeScript ESTree to allow for ESLint to lint TypeScript source code.
Other
915 stars 92 forks source link

Breaking: typescript-estree v5 #538

Closed kaicataldo closed 5 years ago

kaicataldo commented 5 years ago

Following up on https://github.com/JamesHenry/typescript-estree/pull/22, this updates to the latest version of typescript-estree.

Looks like it might also fix https://github.com/eslint/typescript-eslint-parser/issues/503.

I think we should remove support for ecmaFeatures in the options and add individual feature flags if we need them in the future (which seems unlikely). Thoughts?

not-an-aardvark commented 5 years ago

FYI, I renamed the label in this repository from "DO NOT MERGE" to "do not merge" so that the bot will add a pending status check for it. Hopefully the pending status check is a stronger signal to not merge something than the capitalization.

platinumazure commented 5 years ago

FYI: In another issue, I promised I would cut a major release (to change ESLint from a dependency to a peerDependency/devDependency) at some point. I think it would be great to include both changes in the next major release. I'm okay with handling the release, but if you would prefer to do it, let me know if you have questions.

So in summary: Please merge this whenever you feel ready, but please consult me or at least check the package.json file before cutting a release. Thanks!

kaicataldo commented 5 years ago

@platinumazure I'm going to merge this now. Happy to take on those other changes and cut a release!

kaicataldo commented 5 years ago

PR here