search

eslint / typescript-eslint-parser

An ESLint custom parser which leverages TypeScript ESTree to allow for ESLint to lint TypeScript source code.
Other
915 stars 92 forks source link

Fix: missing visitor-keys #554

Closed armano2 closed 5 years ago

armano2 commented 5 years ago

This PR allows visiting

there is way way more missing properties in visitor tree, but this is going to unblock eslint-plugin-typescript from upgrading to latest version

https://github.com/bradzacher/eslint-plugin-typescript/pull/174

jsf-clabot commented 5 years ago

CLA assistant check
All committers have signed the CLA.

mysticatea commented 5 years ago

Thank you for this PR!

Would you update the code in order to visit AST in the location order? For example, it should visit decorators before type annotations.

For visitorKeys, ESLint visits the order as same as the visitorKeys array order.

armano2 commented 5 years ago

@mysticatea thank you, code updated

armano2 commented 5 years ago

@mysticatea tomorrow i'm going to make a ticket listing all (or most) of missing fields in visitor, there is few of them :>