search

eslint / typescript-eslint-parser

An ESLint custom parser which leverages TypeScript ESTree to allow for ESLint to lint TypeScript source code.
Other
916 stars 75 forks source link

Fix: visiting superTypeParameters in classes #561

Closed armano2 closed 6 years ago

armano2 commented 6 years ago

This PR is adding superTypeParameters to class like types ClassDeclaration, ClassExpression, TSAbstractClassDeclaration and fixes order of TSAbstractClassDeclaration

armano2 commented 6 years ago

@platinumazure should i put each one of missing visitor key in each own PR or should i make one big PR?

platinumazure commented 6 years ago

@armano2 Up to you. Please spare a thought for the poor reviewer that has to review a 1000+ line PR :smile: But if it's not that big, you could do one or a few PRs rather than one per node type.

armano2 commented 6 years ago

its more than 1k line with tests xd, i'm asking because some stuff do collide

lets say, TSAbstractClassProperty and TSAbstractClassDeclaration is missing decorators, but i already changed those lines here, and we are going to have conflicts,

i made overview in #555

platinumazure commented 6 years ago

@armano2 I would say do what is most convenient for you and worst case, we can ask for changes. I'm not super worried-- I trust you will have good judgment. (If there are areas of code where collisions would happen, let's do those in combined PRs to make things easier.)

platinumazure commented 6 years ago

@armano2 Merged, thanks for contributing!