search

eslint / typescript-eslint-parser

An ESLint custom parser which leverages TypeScript ESTree to allow for ESLint to lint TypeScript source code.
Other
915 stars 92 forks source link

Upgrade: typescript-estree ^5.3.0 #573

Closed kaicataldo closed 5 years ago

kaicataldo commented 5 years ago

This PR updates typescript-estree to the most recent release. Of note is this addition: https://github.com/JamesHenry/typescript-estree/commit/8787f16b92ba1bf890c4a52cba3ffec625b6d4ba

Is there a reason we want to lock the version? It seems like we should be able to use ^, as the project follows semver.

platinumazure commented 5 years ago

@kaicataldo Oops, I introduced conflicts here by merging #574 (which upgraded to typescript-estree 5.3.0 with no caret). Sorry, but would you mind rebasing or merging in upstream changes when you have time?

kaicataldo commented 5 years ago

Now that https://github.com/eslint/typescript-eslint-parser/pull/567 has landed and the project is already using typescript-estree v5.3.0, I'm not sure how much value I'm adding here. But I do think using ^ makes sense! Thoughts?

kaicataldo commented 5 years ago

On second thought, I'm just going to go ahead and close this. Let's re-evaluate whether we want to auto update minor versions the next time we upgrade.

corbinu commented 5 years ago

@kaicataldo I would also think that the ^ would help. I would think you could switch this or create another PR now that 6.0.0 is out and add the caret then

armano2 commented 5 years ago

6.0.0 has breaking changes

corbinu commented 5 years ago

Yes I was suggesting a PR could be opened for it now though and we could handle the caret change on that one.