search

eslint / typescript-eslint-parser

An ESLint custom parser which leverages TypeScript ESTree to allow for ESLint to lint TypeScript source code.
Other
915 stars 92 forks source link

Breaking: Bump to typescript-estree@6.0.0, typescript@~3.2.1 #576

Closed nevir closed 5 years ago

nevir commented 5 years ago

From what I can tell, the main change in typescript-estree is added support for BigIntLiterals. Added some snapshots for 'em, as well.

Should this be a major bump due to the typescript upgrade? Or only minor?

jsf-clabot commented 5 years ago

CLA assistant check
All committers have signed the CLA.

armano2 commented 5 years ago

can you add new nodes to visitor-keys

kaicataldo commented 5 years ago

Given the discussion in this PR, the team seems to be in general consensus that the "supported TS version" change is a breaking change.

nevir commented 5 years ago

can you add new nodes to visitor-keys

Hmm, I'm not quite sure which nodes would need to be added to visitor-keys (and by that, you mean ./visitor-keys.js?). Seems like this is only adding a new literal value type (BigIntLiteral), and that doesn't seem to fit with the structure of that file. I admit, though, I'm not too familiar w/ how eslint juggles the AST.

Do you mind also updating the readme with the supported TS version range?

👍 Done. Also switched the version constraint to a ^, as suggested in https://github.com/eslint/typescript-eslint-parser/pull/573#issuecomment-443797291

armano2 commented 5 years ago

@nevir you should just add "BigIntLiteral": [] to ./visitor-keys.js

platinumazure commented 5 years ago

Is BigIntLiteral a node type? Or is it a type of the existing Literal node?

armano2 commented 5 years ago

@platinumazure its new node type https://github.com/JamesHenry/typescript-estree/blob/master/src/convert.ts#L2007

justinanastos commented 5 years ago

I just wanted to chime in and say thank you to everyone who's working on this! Great work!

nevir commented 5 years ago

Added the node type

nevir commented 5 years ago

@kaicataldo, is there anything else you'd like me to tweak?

platinumazure commented 5 years ago

Hi @nevir, apologies for letting this sit over the holidays.

Is this PR still needed now that #589 has been created?

JamesHenry commented 5 years ago

Thanks a lot for this @nevir and I am sorry for the delay - your commits (with you still as the author) are included directly in https://github.com/eslint/typescript-eslint-parser/pull/596, so I am closing this in favour of that one.

Thanks again!