search

eslint / zh-hans.docs.eslint.org

Simplified Chinese website
Apache License 2.0
15 stars 4 forks source link

feat: sync v8.31.0 #94

Closed kecrily closed 1 year ago

kecrily commented 1 year ago

Prerequisites checklist

What is the purpose of this pull request?

sync v8.31.0 from eslint repo

What changes did you make? (Give an overview)

Related Issues

Is there anything you'd like reviewers to focus on?

netlify[bot] commented 1 year ago

Deploy Preview for zh-hans-docs ready!

Name Link
Latest commit 26d3c51efd2fc0b5f0f1c84ea372aac49d0d156f
Latest deploy log https://app.netlify.com/sites/zh-hans-docs/deploys/63fa19d54256b50008b12bea
Deploy Preview https://deploy-preview-94--zh-hans-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

kecrily commented 1 year ago
  1. Should we also include the fix in formatters/index.md? (eslint/eslint@d9a39c7)

I will update it.

  1. Since we're copying all files, the left sidebar menu now has duplicate items (e.g., there is [用户指南] and Use ESLint in your project). Is that okay for now?

Structural changes are included in v8.32.0. I will finish it sync as soon as possible.

I think this PR should be merged together at the same time as the upcoming sync PR for v8.32.0 is approved. Before that this PR should be blocked.

ollie-iterators commented 1 year ago

This would be great to install because the chinese documentation has two versions of the links on the documentation site. See: https://zh-hans.eslint.org/docs/latest/

nzakas commented 1 year ago

@kecrily are you saying we should merge #95 before this one or after it?

kecrily commented 1 year ago

@kecrily are you saying we should merge #95 before this one or after it?

I originally thought that the current site did not deploy commits with structural changes, so needed to merge both v8.31.0 and v8.32.0 to avoid duplicate content.

But it turns out that I was wrong, and the current site has already deployed the commits that have changed structure, so in normal order, v8.31.0 is merged first and then v8.32.0 is merged.

But we should also merge v8.32.0 as soon as possible, because it's too bad that the menu bar has duplicate content.

I also plan to take steps to have the version of content automatically pulled match the translated version, rather than always pulling the latest docs.

nzakas commented 1 year ago

Makes sense!

mdjermanovic commented 1 year ago

Note that the HTML formatter page that should appear in an iframe is missing, but that doesn't seem to be caused by this particular change.

image

mdjermanovic commented 1 year ago

I think this PR should be merged together at the same time as the upcoming sync PR for v8.32.0 is approved. Before that this PR should be blocked.

Makes sense, I'll let you merge this when and how you think it would be best.

kecrily commented 1 year ago

Sorry it took so long to process, but my computer recently broke down and just got fixed.