search

esm-bundle / autopublish-template

MIT License
5 stars 0 forks source link

Packages failing to publish since release-it v15 upgrade #349

Open StephenCooper opened 2 years ago

StephenCooper commented 2 years ago

I have just noticed that all the packages based off this template have been failing to publish new versions since the release-it dependency was automatically upgraded to v15 as part of https://github.com/esm-bundle/autopublish-template/pull/327. The tests do not run the publish step, hence why this was automatically merged.

For example, the GitHub Action for the esm-bundle/react publish step is failing with the following error. https://github.com/esm-bundle/react/runs/6240303850?check_suite_focus=true

Run pnpm run release
> @esm-bundle/react@17.0.2-fix.1 release /home/runner/work/react/react
> release-it
ERROR Package subpath './lib/plugin/Plugin.js' is not defined by "exports" in /home/runner/work/react/react/node_modules/release-it/package.json
 ERROR  Command failed with exit code 1.

From what I can see this is most likely because of https://github.com/release-it/release-it/issues/909 which breaks non esm projects.

I am fairly new to all these things but I wonder if in the short term it would be possible to pin release-it to v14 to enable the GitHub actions to succeed again?

flying-sheep commented 2 years ago

@markcellus created https://www.npmjs.com/package/release-it-cjs, maybe that can be used?

It’s ironic that this project’s packages were broken by that move, since this project exists to provide ESM packages for packages that aren’t there yet …