esm-dev / esm.sh

A fast, smart, & global CDN for modern(es2015+) web development.
https://esm.sh
MIT License
2.95k stars 143 forks source link

Handle webpack 3 minified umd #841

Closed lewisl9029 closed 4 weeks ago

lewisl9029 commented 4 weeks ago

Hi there! Back again with another minified umd detection PR, this time handling webpack 3's output for the highcharts-react-official library.

Luckily, it looks like the only material difference in output between 3 and 4 is the statement order, so all that was needed to fix the test was to handle both positions.

Btw, when did the playground start adding ?dev to all imports? Is there a way to override this for repro'ing prod issues? When I first tried to repro this I was surprised to see it working in the playground. Turns out it only works because of the dev flag (presumably because the dev version uses one of the non-minified builds?).

ije commented 4 weeks ago

Btw, when did the playground start adding ?dev to all imports? Is there a way to override this for repro'ing prod issues? When I first tried to repro this I was surprised to see it working in the playground. Turns out it only works because of the dev flag (presumably because the dev version uses one of the non-minified builds?).

you're right, it's unnecessary to add ?dev flag, going to get rid of it.