esm-dev / esm.sh

A fast, smart, & global CDN for modern(es2015+) web development.
https://esm.sh
MIT License
2.95k stars 143 forks source link

esbuild target: User-Agent not working #848

Open bubbajoe opened 4 days ago

bubbajoe commented 4 days ago

Getting the target via the query params seems to work... curl https://esm.sh/yaml@2.4.5\?target\=es2015

however, using the user agent does not seem to work curl https://esm.sh/yaml@2.4.5 -H User-Agent:esm/es2015

Additionally, on the esm.sh website, it mentions By default, esm.sh checks the User-Agent header to determine the build target.

but doesn't mention how it does that, it would be nice to mention how this works, I had to check the code and still didn't work.

ije commented 4 days ago

there are lot of changes i didn't deploy to the production yet, including support of User-Agent:esm/es20xx

bubbajoe commented 3 days ago

Sorry I am confused, why was the esm/es20xx change just removed?

image
ije commented 3 days ago

this is introduced in v136, currently production is v135

bubbajoe commented 3 days ago

Thanks, when is the next planned release?