search

esm-dev / esm.sh

A fast, smart, & global CDN for modern(es2015+) web development.
https://esm.sh
MIT License
3.07k stars 147 forks source link

Fixing some windows issues - path slashes #851

Closed firtoz closed 3 months ago

firtoz commented 3 months ago

Was trying to run the project in windows and it had made some really funky paths.

1: some paths had mixed back and forward slashes 2: some paths were incorrectly concatenated, like C:/Users/frtn/.esmd/npm/react@18.3.1/node_modules/C:/Users/frtn/.esmd/npm/react@18.3.1/node_modules/.pnpm/react@18.3.1/node_modules/react

Trying to fix both in here.

Tested only in my windows computer and things seem to work well with a few packages I tried, so you may need to test it yourself before merging for the other OSs to make sure I didn't break them 😅

firtoz commented 3 months ago

Hold - found other windows issues, will try to fix in this PR

firtoz commented 3 months ago

Oh, esbuild has more issues, so nvm I guess...

ije commented 3 months ago

sorry, i never try to develop this project on a Windows machine

ije commented 3 months ago

thanks anyway!