esm-dev / esm.sh

The no-build CDN for modern web development.
https://esm.sh
MIT License
3.15k stars 151 forks source link

Failed to import - `many-keys-map` | Old Pluto.jl exports #879

Open pankgeorg opened 2 months ago

pankgeorg commented 2 months ago

Failing module

import ManyKeysWeakMap from "https://cdn.esm.sh/v64/many-keys-weakmap@1.0.0/es2021/many-keys-weakmap.js"

Error message

After onload I got this:

GET https://esm.sh/v64/many-keys-weakmap@1.0.0/es2021/many-keys-weakmap.js net::ERR_ABORTED 500 (Internal Server Error)

Additional info

crossref: https://github.com/fonsp/Pluto.jl/issues/3019 and https://github.com/fonsp/Pluto.jl/issues/2707 context: Pluto HTML bundles that are on the internet and refer to ESM are more-or-less immutable, as they were usually built as part of some course that has now ended, so it's not maintained.

ije commented 2 months ago

the url should be https://esm.sh/v64/many-keys-weakmap@1.0.0/es2021/many-keys-weakmap.mjs now

fonsp commented 2 months ago

Hey! The problem in our project is that we version-pinned the esm.sh URL to future-proof the import. So we used

import ManyKeysWeakMap from "https://cdn.esm.sh/v64/many-keys-weakmap@1.0.0/es2021/many-keys-weakmap.js"

with the assumption that this would work forever, by pinning the esm.sh version, the package version and the compile target.

This import is baked into some archived html files that we generated in the past, and these files suddenly stopped working. Since this was an archival project, we can't change the import.

Is it possible to make the original import (with .js) work again, for versions where this worked in the past?

fonsp commented 3 days ago

Hi @ije, could you take a look at this?

ije commented 3 days ago

@pankgeorg i will fix it asap! this is broken by https://github.com/esm-dev/esm.sh/releases/tag/v112

ije commented 3 days ago

hi @fonsp, i just added a patch for the issue, now it works again https://esm.sh/v64/many-keys-weakmap@1.0.0/es2021/many-keys-weakmap.js

fonsp commented 3 days ago

Hey that's awesome, thanks so much!!