search

esm-dev / esm.sh

A fast, smart, & global CDN for modern(es2015+) web development.
https://esm.sh
MIT License
3.12k stars 150 forks source link

Bug in the docker version when using the special search param syntax for import map trailing slash #896

Open arieussec-smartsheet opened 1 week ago

arieussec-smartsheet commented 1 week ago

So this issue only seems to happen when I run esm.sh in Docker. The live version works fine...

Requesting http://localhost:8089/redux-first-router-link@2.1.1&deps=redux-first-router@2.1.1/ using & instead of ? to work in import maps results in this response:

invalid package name 'redux-first-router-link@2.1.1&deps=redux-first-router'

But when I use ? then it works correctly. It seems to be caused by the second @

ije commented 1 week ago

i just bumped the docker image to v135_7 thats fixs the url issue, please try again! thanks

docker pull ghcr.io/esm-dev/esm.sh:v135_7
arieussec-smartsheet commented 1 week ago

Hi @ije I don't see that version on https://github.com/esm-dev/esm.sh/pkgs/container/esm.sh

ije commented 1 week ago

sorry i forgot to update the tagname in the CI, will fix soon