search

esm-tools / esm_runscripts

GNU General Public License v2.0
3 stars 5 forks source link

additional_flags from machine.yaml are not handled correctly #184

Open seb-wahl opened 3 years ago

seb-wahl commented 3 years ago

Version: latest version of all tools, geomar branch of esm_tools

When I add

computer:
   additional_flags:
      - --mem=72000
      - --contraint="cascade"

to a runscript the extra flags are correctly added to the sbatch header of my runscript. However if add the same settings to my machine.yaml the are (as seen in the the *finished*.yaml) either resolved incorrectly or ignored. I tried

computer:
   additional_flags:
      - --mem=72000
      - --contraint="cascade"

and

additional_flags:
      - --mem=72000
      - --contraint="cascade"

in my machine yaml. It does not matter whether I used strings or lists. I added a few print statements in batch_system.py which clearly show me that the additional_flags are already empty when they shall be processed in batch_system.py. So I assume something must go wrong when the machine.yaml is parsed.

What's going wrong here?

denizural commented 3 years ago

I can reproduce that. I am working on it now

denizural commented 3 years ago

Hi @seb-wahl, could you please look at the hotfix here: https://github.com/esm-tools/esm_parser/pull/77 I hope it will solve your issue.

pgierz commented 2 years ago

Did this work? If yes, please close the issue: we are trying to get less open things at the moment so we can make new issues of whatever needs to be solved and get the rest off the never-dying "list"