esm-tools / esm_tools

Simple Infrastructure for Earth System Simulations
https://esm-tools.github.io/
GNU General Public License v2.0
25 stars 12 forks source link

Draft: Feat/awicm3 v3.3 #1124

Closed JanStreffing closed 4 months ago

JanStreffing commented 5 months ago

At the moment this PR looks giant, but it will be much reduced once https://github.com/esm-tools/esm_tools/pull/1127 is in.

@mandresm, I have the impression https://github.com/esm-tools/esm_tools/pull/1162 impacted this script:

https://github.com/esm-tools/esm_tools/blob/bc8b97d2f23bdba1e020bb1fea35ccb5ecd44eea/configs/components/oifs/append_daily_icmcl_file.sh#L15

This directory, argument $6 is called like so:

https://github.com/esm-tools/esm_tools/blob/bc8b97d2f23bdba1e020bb1fea35ccb5ecd44eea/configs/components/oifs/oifs.yaml#L1020

Can it be, that at this point in the workflow:

https://github.com/esm-tools/esm_tools/blob/bc8b97d2f23bdba1e020bb1fea35ccb5ecd44eea/configs/components/oifs/oifs.yaml#L1412-L1412

What is stored in the work_dir variable has changed? From the logic as written, I would expect this to point at something like: /work/ab0246/a270092/runtime/awicm3-v3.3//v3.3_test3/run_20000101-20000101/work/. In my latest test it points at /work/ab0246/a270092/input/oifs-48r1/, which is in the pool dir.

JanStreffing commented 5 months ago

I was trying to work on the previous error and managed to build in another one. I saw that right now, we always compile --with-cplng2:

https://github.com/esm-tools/esm_tools/blob/2c556e13861a663bfbd16adb70b058878ab886bb/configs/components/oifs/oifs.yaml#L276

This should only be the case when we are coupled, not for oifs-48r1 standalone. So remove it in the oifs.yaml

  48r1:
    branch: 'dev/integrate-with-ece4'
    cplng_flag: ""
    comp_command: "./openifs-bundle create; ./openifs-bundle build --threads=32 --openifs-only --without-single-precision --with-oifs-xios --install; chmod -R ${source_code_permissions} .; mv install/bin/ifsMASTER.DP install/bin/oifs"

And add a new comp command in the awicm3.yaml setup file:

oifs:
        choose_general.major_version:
                "v3.3":
                        version: "48r1"
                        with_xios: True
                        comp_command: "./openifs-bundle create; ./openifs-bundle build --threads=32 --openifs-only --without-single-precision --with-cplng2 --with-oifs-xios --install; chmod -R ${source_code_permissions} .; mv install/bin/ifsMASTER.DP install/bin/oifs"

This is ignored at compile time. I just get the default standalone compile command.

JanStreffing commented 5 months ago

At the moment this PR looks giant, but it will be much reduced once #1127 is in.

@mandresm, I have the impression #1162 impacted this script:

https://github.com/esm-tools/esm_tools/blob/bc8b97d2f23bdba1e020bb1fea35ccb5ecd44eea/configs/components/oifs/append_daily_icmcl_file.sh#L15

This directory, argument $6 is called like so:

https://github.com/esm-tools/esm_tools/blob/bc8b97d2f23bdba1e020bb1fea35ccb5ecd44eea/configs/components/oifs/oifs.yaml#L1020

Can it be, that at this point in the workflow:

https://github.com/esm-tools/esm_tools/blob/bc8b97d2f23bdba1e020bb1fea35ccb5ecd44eea/configs/components/oifs/oifs.yaml#L1412-L1412

What is stored in the work_dir variable has changed? From the logic as written, I would expect this to point at something like: /work/ab0246/a270092/runtime/awicm3-v3.3//v3.3_test3/run_20000101-20000101/work/. In my latest test it points at /work/ab0246/a270092/input/oifs-48r1/, which is in the pool dir.

This problem has been solved. Turns out I had changed the path to the ICMCL file in pool dir by adding a resolution sub dir. ty @pgierz

JanStreffing commented 4 months ago

superseeded by #1193 1193