search

esm-tools / esm_tools

Simple Infrastructure for Earth System Simulations
https://esm-tools.github.io/
GNU General Public License v2.0
25 stars 12 forks source link

Setting use_venv in runscipt has no effect #1150

Closed nwieters closed 2 months ago

nwieters commented 3 months ago

Describe the bug Setting the variable use_venv in runscript -> general section has no effect, since it will be overwritten by None from command_line_config. This causes esm_runscripts to always asking whether an venv should be generated. Even if set to False in the runscript.

To Reproduce Call esm_runscripts without --open-run

Expected behavior Runscript variable for use_venv should be taken when no --open-run is given as argument.

Screenshots If applicable, add screenshots to help explain your problem.

System (please complete the following information):

esm_tools, version 6.29.0

Additional context Add any other context about the problem here.

nwieters commented 2 months ago

Short update. Thank you @JanStreffing for your comment in the ESM-Tools meeting. This error is new in release. I will try to find the commit that introduced it and implement a fix.

JanStreffing commented 2 months ago

good to know. last version bump in my branch is: https://github.com/esm-tools/esm_tools/commit/9e2cae8b58b70a41e76096fe74b1083d0bbd635f