search

esm-tools / esm_tools

Simple Infrastructure for Earth System Simulations
https://esm-tools.github.io/
GNU General Public License v2.0
25 stars 12 forks source link

Feat/loguru #1153

Closed pgierz closed 2 months ago

pgierz commented 3 months ago

Replaces all print statements with loguru statements.

mandresm commented 3 months ago

Hey @pgierz! thanks for this development! Do you have any idea why are the tests failing?

pgierz commented 3 months ago

Looks like a "general" bug in the CI's ubuntu platform. HDF5 is not able to install...? I can have a more detailed looked after the data science seminar.

nwieters commented 2 months ago

Hi, I think I fixed all logger calls. From my side it is ready to be merged. There is just one change by @pgierz I am not sure about. The deletion of a sys.exit(2) call in oasis.py. I made a remark in the review. @mandresm and @pgierz maybe you can have a look at it again.

nwieters commented 2 months ago

Just found one small bug that broke the tests.

mandresm commented 2 months ago

bump