esm-tools / esm_tools

Simple Infrastructure for Earth System Simulations
https://esm-tools.github.io/
GNU General Public License v2.0
25 stars 12 forks source link

Improvements on filemovements #1162

Closed mandresm closed 1 month ago

mandresm commented 2 months ago

This PR aims to:

This is to reduce the copying times of @tsemmler05, @a270067 and @mjy1011.

@JanStreffing and @mjy1011, this branch is not in it's final stage, but it would be a great help if you can check that is working for an actual simulation. I've tested already a bit but not in depth.

JanStreffing commented 2 months ago

This week I will be back. Hopefully be Wednesday or so, I get to give this a test.

mandresm commented 2 months ago

I consider this finished, so feel free to give it a try. I will work on the parallelization on another PR, and that would take longer.

PD: Wednesday is bank holiday ;)

mjy1011 commented 2 months ago

Hi Miguel, thank you very much for the modification. On Aleph when we restart experiment with the updated codes, attached error occurs. It seems oifs restart info files (rcf, waminfo)' path are not detected correctly.

run_error

Do we need to modify any other files? for example, /esm_tools/configs/esm_software/esm_runscripts/defaults.yaml ?

mandresm commented 2 months ago

Hi @mjy1011, I'll be looking into this today. The problem is that the preprocessing scripts expect files in the intermediate folders.

mandresm commented 2 months ago

Hi @mjy1011,

I've got done some progress today with the issue, but there are some weird errors still. I think I am close, but I'll have to continue tomorrow.

mjy1011 commented 2 months ago

Hi @mjy1011,

I've got done some progress today with the issue, but there are some weird errors still. I think I am close, but I'll have to continue tomorrow.

That's nice. Thank you for the update.

mandresm commented 2 months ago

Hi @mjy1011,

That was a real tough one... but I think it's working now. Can you please try?

@JanStreffing, can you try if the results are bit identical with release and this branch? I am getting non-bit identical results in some OpenIFS output files and restarts, and I am wondering if that's normal? (for example, maybe the results in the files are identical but there is something different in the headers)

mjy1011 commented 2 months ago

Hi @mjy1011,

That was a real tough one... but I think it's working now. Can you please try?

@JanStreffing, can you try if the results are bit identical with release and this branch? I am getting non-bit identical results in some OpenIFS output files and restarts, and I am wondering if that's normal? (for example, maybe the results in the files are identical but there is something different in the headers)

Hi ~~ I am waiting for the pre-running job to be finished. I'll try and let you know in a few days. Nice work again!

mandresm commented 2 months ago

Looks good!

Only a few minor changes (and one typo 😉)

Thanks for the review!

mjy1011 commented 1 month ago

Hi @mjy1011, That was a real tough one... but I think it's working now. Can you please try? @JanStreffing, can you try if the results are bit identical with release and this branch? I am getting non-bit identical results in some OpenIFS output files and restarts, and I am wondering if that's normal? (for example, maybe the results in the files are identical but there is something different in the headers)

Hi ~~ I am waiting for the pre-running job to be finished. I'll try and let you know in a few days. Nice work again!

Just confirmed it is working right! And most of all, saving more than 2 hours, amazing. Thank you very much!

mandresm commented 1 month ago

approve-changes

mandresm commented 1 month ago

Just confirmed it is working right! And most of all, saving more than 2 hours, amazing. Thank you very much!

You are welcome, and thanks for your patience with this issue :)

mandresm commented 1 month ago

bump