esm-tools / esm_tools

Simple Infrastructure for Earth System Simulations
https://esm-tools.github.io/
GNU General Public License v2.0
26 stars 12 forks source link

Feat/echam streams #1240

Open pgierz opened 1 month ago

pgierz commented 1 month ago

Automatically create ECHAM streams from mvstreamctl filetags.

Should be useful for #1239

pgierz commented 3 weeks ago

The latest few commits use the extremely useful feature of being able to write tests directly in your docstrings under the examples section. The included files are referenced directly from the root of the repo in the CI actions. Check it out 😄

src/esm_runscripts/echam.py::esm_runscripts.echam._get_mvstream_tags_from_namelist PASSED [ 71%] src/esm_runscripts/jsbach.py::esm_runscripts.jsbach._get_comments_for_streams PASSED [ 85%]

mandresm commented 3 weeks ago

Some of the dryruns in esm_tests are failing

mandresm commented 3 weeks ago

Once the CI tests work, I would recommend running esm_tests in levante with this branch to check that also actual simulations run correctly. I can take care of that to unload you a bit @pgierz. Just let me know when I can go ahead and run the real tests

pgierz commented 3 weeks ago

Should be good to go. The failing levante tests mainly fail due to changes in how the streams get picked up, as well as new main keys in the echam config, e.g.:

    Differences in run/awicm/awicm1-CMIP6-initial-monthly//run_18500101-18500131/config//awicm1-CMIP6-initial-monthly_finished_config.yaml:
        --- 
        +++ 
        @@ -118,6 +118,7 @@
           forcing_dir: /pool/data/ECHAM6//input/r0007/T127
           greenhouse_dir: /pool/data/ECHAM6/
           namelist_dir: <HOME_DIR>/esm_tools/namelists//echam/6.3.04p1/PI-CTRL
        +  has_namelist_streams: true