esm-tools / esm_tools

Simple Infrastructure for Earth System Simulations
https://esm-tools.github.io/
GNU General Public License v2.0
25 stars 12 forks source link

empty add_ block causes unexpected behaviour #215

Closed seb-wahl closed 2 years ago

seb-wahl commented 3 years ago

Describe the bug During a test I ended up with the following block in a yaml file (do you spot the error :-) ):

...
runtime_environment_changes:
  choose_computer.name:
    blogin:
      add_module_actions:
      add_export_vars:
        - 'OIFS_FFIXED=""'
        - 'GRIB_SAMPLES_PATH="$ECCODESROOT/share/eccodes/ifs_samples/grib1_mlgrib2/"'
        - 'DR_HOOK_IGNORE_SIGNALS="-1"'
...

In the above case the settings below weren't used as expected and e.g. the export vars not set. WARNING: I can't exactly recall, whether the setup was exactly as described above, but maybe it's still helpful to check if empty sections are handled correctly. To Reproduce Well, just do the same (stupid) thing that I did

Expected behavior Not use the block add_module_actions: and continue

System (please complete the following information):

Additional context WARNING: I can't exactly recall, whether the setup was exactly as described above, but maybe it's still helpful to check if empty sections are handled correctly.

JanStreffing commented 2 years ago

I just did a test run with:

fesom:
    add_export_vars:
    add_namelist_changes:
        namelist.oce:
            oce_dyn:
                gamma0: "1"

The empty add block did not trip up esm_tools. I assume the issue is solved. Closing here. If it reappears, reopen please.