search

esm-tools / pymorize

A Python based Tool to CMORize NetCDF Data
MIT License
0 stars 1 forks source link

Units #10

Closed siligam closed 2 months ago

siligam commented 3 months ago

addressing issue #6

Just implemented the bare logic to handle unit conversion. No API design yet. Features:

Normalisation of non-standard notation of units in netcdf4 so pint can read them. added unit definitions which are not available in pint library.

mandresm commented 3 months ago

Closes #6

siligam commented 2 months ago

Excellent work @siligam! I only have one more small thing that you should look at, just to be sure: The metadata attribute name on units should be plural (it already is), but I am not 100% sure so I'd like to double check.

I checked that units are indeed plural and I am sure I did use plural when setting the attribute.

You can also add a call to handle_unit_conversion to the generic pipeline. We can have a brief meeting so I can show you where to do that! Once that is in place, we can merge this into the main branch 🙂

Sure we can discuss this in a brief meeting.