search

esm7 / obsidian-rtl

RTL support for Obsidian.md
MIT License
137 stars 11 forks source link

Wrong direction of block-quote's line #43

Open GuySuday opened 1 year ago

GuySuday commented 1 year ago

In RTL: image

In LTR: image

I would expect the block-quote's line to be on the right side on RTL.

Thank you :)

srezasm commented 1 year ago

@esm7 Take a look at this problem if you got time. Thank you.

esm7 commented 1 year ago

It makes sense for RTL, but now that we have the auto mode (which I assume should be the most common for most users), I wonder what should be the right behavior. Because if we set the line to be on the left or on the right depending on each line's direction, and some lines will be LTR and some RTL it will kill a block's "block" look...

srezasm commented 1 year ago

Keep the default behavior as is for auto mode, but make it stick to the right for rtl mode.

zoli commented 1 year ago

It makes sense for RTL, but now that we have the auto mode (which I assume should be the most common for most users), I wonder what should be the right behavior. Because if we set the line to be on the left or on the right depending on each line's direction, and some lines will be LTR and some RTL it will kill a block's "block" look...

Maybe take sort of "strong directionality" concept based on first block-quote line?