search

esmero / ami

Archipelago Multi Importer. A module of mass ingest made for the masses
GNU Affero General Public License v3.0
2 stars 4 forks source link

Create a Log for Twig Template and JSON Failures #128

Open karomabiles opened 2 years ago

karomabiles commented 2 years ago

WHAT?

A system log/report type that provides information on Twig template ---JSON Failures/Errors and vice versa.

It's all in the details - report expectations (wants)

This issue relates to issues #37 and #92.

@alliomeria Can you think of anything else that would be helpful to add in report details?

alliomeria commented 2 years ago

@karomabiles think all the other components @DiegoPino put in place via https://github.com/esmero/ami/pull/123 cover what's needed. 😄

For the entry for specific Twig template + JSON errors, an entry along the lines of the current message being generated would be very helpful (icing on the Report 🍰): $message = $this->t('Sorry, we can not cast ADO with @uuid into proper Metadata. Check the Metadata Display Template used, your permissions and/or your data ROW in your CSV for set @setid.',[ '@uuid' => $data->info['row']['uuid'], '@setid' => $data->info['set_id'] ]);

DiegoPino commented 2 years ago

Thanks @karomabiles and @alliomeria. I can add the ROW and a bit more detail. I can sadly not add which Column made the JSON fail because the whole JSON will be "rejected" as JSON and thus I will be blind to what part is wrong. But I can give you the general JSON error (e.g Invalid Document, etc) too

DiegoPino commented 2 years ago

And also the Link to the Twig template. That I can do!

alliomeria commented 2 years ago

Sounds great @DiegoPino! Thank you!

DiegoPino commented 2 months ago

I think a piece is missing still? Will keep open. Re-tagging for 0.9.0