esmero / ami

Archipelago Multi Importer. A module of mass ingest made for the masses
GNU Affero General Public License v3.0
2 stars 4 forks source link

Modern JS (latest 112.0.5615.121 (Official Build) (x86_64)) and our wonky #states bug #162

Closed DiegoPino closed 1 year ago

DiegoPino commented 1 year ago

What?

Allison just found a bug using her shiny new stack (in my defense I debugged it)

Our AMI preview Form overrides and #states are not conforming to modern CSS selectors (which became more strict)

@aksm @alliomeria this requires an audit on all our stack

e.g input[name="some_element"

needs to be :input[name="some_element"]

In old times (before today) all worked well. So .. there is that

DiegoPino commented 1 year ago

Solved via https://github.com/esmero/ami/commit/ddbccb2cd0926498b1fc3fff436bf293cbd20719