esmero / ami

Archipelago Multi Importer. A module of mass ingest made for the masses

GNU Affero General Public License v3.0

2 stars 4 forks source link

Add notice for Update Modes so people become aware that a template driven update Might generate more keys #170

Closed DiegoPino closed 2 months ago

DiegoPino commented 1 year ago

What?

This has happened too many times: We do an replace update, but mapping to a twig template. The CSV has only the keys we want to replace but because all is mediated by a template the template itself generates new empty keys that end replacing good metadata we don't want.

A simple extra (IN BOLD) notice for the two replacement modes warning people about that, will (hopefully) make everyone think twice before applying a template blindly! And save many revisions to us/everyone.

alliomeria commented 2 months ago

Somewhat helped by https://github.com/esmero/ami/pull/204...

DiegoPino commented 2 months ago

Fixed via https://github.com/esmero/ami/commit/427f09b7ec88cdd91bab47c99b5d10abe02108f3 by @alliomeria