search

esmero / ami

Archipelago Multi Importer. A module of mass ingest made for the masses
GNU Affero General Public License v3.0
2 stars 4 forks source link

AMI remote file Mimetype (yes again) renames extensions #173

Closed DiegoPino closed 2 months ago

DiegoPino commented 1 year ago

What?

This is not an error per se. Using the normalized extension based on the actual remote Mime Type is OK. But for a specific need, 3D Models, where the exact name of a texture inside an Material file requires a 1:1 match this breaks things.

Need to debug exactly where this is happening bc reading my code I assumed I was already doing this, doing a reverse mapping from MimeType to extension, a normal from extension to Mime Type and only if both differed I used the calculated one. But there might be an IF or a logic conditional that is always ending in renaming. The specific case is JPG v/s JPEG

DiegoPino commented 1 year ago

Gosh. This is auto-inflicted pain. See https://github.com/esmero/strawberryfield/commit/8ebc80d614e0aec84f44a519fe2e7172a535e3a0 We are doing this to ourselves by trying to correct wrong remote Content-Types coming from Islandora ....

DiegoPino commented 2 months ago

Resolved