esmero / ami

Archipelago Multi Importer. A module of mass ingest made for the masses
GNU Affero General Public License v3.0
2 stars 4 forks source link

Metadata Preview AMI set for Add Metadata Display #180

Closed aksm closed 2 months ago

aksm commented 1 year ago

What?

Currently, checking an AMI set via Metadata Display Preview requires editing an already saved Metadata Display template. When adding a new template the option for AMI Sets is not available.

It looks like all that's required is to change the following:

https://github.com/esmero/ami/blob/bceee5d1902c9104dc89c6d97b26665d67d7f419/ami.module#L36

to:

function ami_form_metadatadisplay_entity_form_alter(&$form,FormStateInterface $form_state, $form_id)
DiegoPino commented 1 year ago

@aksm means adding extra, or just changing? Thanks for catching this one!

aksm commented 1 year ago

@aksm means adding extra, or just changing? Thanks for catching this one!

@DiegoPino Just changing. The base form hook covers both.

DiegoPino commented 1 year ago

Ok, but the delete one will have a preview then? mmmmm so maybe it needs internal a check of which form is using it?

aksm commented 1 year ago

Ok, but the delete one will have a preview then? mmmmm so maybe it needs internal a check of which form is using it?

@DiegoPino Just checked and the delete form isn't altered by the base form hook.

DiegoPino commented 1 year ago

ok, cool. thx!

DiegoPino commented 2 months ago

Solved