search

esmero / ami

Archipelago Multi Importer. A module of mass ingest made for the masses
GNU Affero General Public License v3.0
2 stars 4 forks source link

Remove cache form Reports log form #190

Closed DiegoPino closed 7 months ago

DiegoPino commented 7 months ago

What?

Because the Reports log tab on an AMI set is an Entity Form (means, it depends on the Entity) there is an edge case where someone visits it before any processing has happened (means the Log is still not created) and Drupal caches (because it uses the entity and the user context) the empty one. Another user, visiting it afterwards will see the Reports, but the original user will keep seeing an empty Form until global caches are cleared (or user caches, tags) or the entity itself changes (someone changes the status, updates a CSV or the JSON config)

The solution so far (but needs more testing) is very simple, make cache last 0.

DiegoPino commented 7 months ago

Resolved (so far) via https://github.com/esmero/ami/commit/830e6d9c255a4ac9e7e0243945f78cc3f978bcb7