esmero / ami

Archipelago Multi Importer. A module of mass ingest made for the masses
GNU Affero General Public License v3.0
2 stars 4 forks source link

ISSUE-193: Forced Downloads will force everything + check on return code/status #194

Closed DiegoPino closed 5 months ago

DiegoPino commented 5 months ago

See #193

Needs testing. But the logic checks in my brain. Will confirm all works as before tomorrow + 401/404 + forced re-download (and ZIP files too) will be processed again even if for some reason some old 401/404 ended staying behind.

@alliomeria everything will be well.

DiegoPino commented 5 months ago

@alliomeria did tests and it works. Not the force download is always respected even if previously we did (before this code) downloaded an 4xx response body. I saw logs being generated, a second pass with cached downloads being faster, a third pass once I opened one of the protected sources being re-downloaded OK and a third pass after deleting and reinvesting working too. Will merge. Further tests on one of the demo machines (which I will update after merging) with real data would be great. Thanks!