search

esmero / ami

Archipelago Multi Importer. A module of mass ingest made for the masses
GNU Affero General Public License v3.0
2 stars 4 forks source link

make sure `ap:tasks` are not overridden by our standardized defaults when updating via an AMI update via replace operation #200

Closed DiegoPino closed 1 month ago

DiegoPino commented 4 months ago

what?

The moment in time, when we check/set the basic required ap:taskjson fields during an AMI Set Update operation is too soon for a "replace" operation. Most replace operations won't have that key at all defined and because we check if they need to be "normalized" on the output of a direct/replace action before we merge back to the whole ADO, we end removing manually set nested keys/values, like the one that allows another label key to be used for node title or even the "not run this SBR processor"

@alliomeria this is what you correctly diagnosed today. Thanks for debugging that. I will fix this. Sorry for the hiccup

alliomeria commented 4 months ago

Thank you for reviewing this together with me live today, and confirming the current setup @DiegoPino! Thank you also for making this issue and adjusting where the ap:tasks are being checked + set. :)

DiegoPino commented 1 month ago

Resolved via https://github.com/esmero/ami/commit/0dda14a4210edbbcd742863d16f7c616e8d8238b